Conversation
…pilation from now on.
|
@pshriwise is this ready to be merged into |
Owner
Author
|
I'll run this through some benchmarks today, but then yeah I'd say it's good to go. Thanks for the ping! |
|
Apologies for being a stick in the mud @pshriwise - have you had a chance to benchmark this change yet? |
Owner
Author
I did! But I didn't manage to relay that here. Should be all set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some downstream packages that are using double-down include additional compiler flags that identify compiler warnings as errors. This PR updates double-down to remove such compiler warnings and adds the
-Wallflag to C++ compilation in CMake so these are more apparent going forward.