Skip to content

update pmtiles dependency to fix issue #193#194

Merged
bdon merged 1 commit intoprotomaps:mainfrom
ycouble:main
May 4, 2025
Merged

update pmtiles dependency to fix issue #193#194
bdon merged 1 commit intoprotomaps:mainfrom
ycouble:main

Conversation

@ycouble
Copy link
Copy Markdown
Contributor

@ycouble ycouble commented Apr 30, 2025

npm run test gets 46/46

@bdon
Copy link
Copy Markdown
Member

bdon commented Apr 30, 2025

If you npm install protomaps-leaflet from scratch it will install pmtiles v.3.2.1 into package-lock.json, since that is allowed by the caret. So I don't think this PR changes anything, ^3.0.7 and ^3.1.0 are basically equivalent.

@ycouble
Copy link
Copy Markdown
Contributor Author

ycouble commented Apr 30, 2025

You're right, however if you get it from cdn, which was my case in this project, I suspect you'll get the version resolved in the package-lock.json, isn't it ?

@bdon
Copy link
Copy Markdown
Member

bdon commented May 4, 2025

Yeah, you are right. I'll merge this for now, thanks.

@bdon bdon merged commit 95b72c9 into protomaps:main May 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants