Fix -Wdeprecated-declarations suppression on Windows#25084
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Fix -Wdeprecated-declarations suppression on Windows#25084copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_850860870
branch
from
e953972 to
1244816
Compare
copybara-service
bot
force-pushed
the
test_850860870
branch
from
1244816 to
733f179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix -Wdeprecated-declarations suppression on Windows
clang on Windows implements GNUC extensions, defines clang, but doesn't define GNUC, so one needs to handle both clang and GNUC cases. Fix this by using the existing PROTOBUF_IGNORE_DEPRECATION_* macros.
This upstreams (an improved version of) one of Chromium's patches: https://source.chromium.org/chromium/chromium/src/+/main:third_party/protobuf/patches/0049-deprecated-declarations-pragma.patch