Improve PHP 8.2 compatibility : Partially-supported callable are deprecated#1979
Open
romaincousseau wants to merge 2 commits intopropelorm:masterfrom
Open
Improve PHP 8.2 compatibility : Partially-supported callable are deprecated#1979romaincousseau wants to merge 2 commits intopropelorm:masterfrom
romaincousseau wants to merge 2 commits intopropelorm:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1979 +/- ##
=========================================
Coverage 89.28% 89.28%
Complexity 8058 8058
=========================================
Files 232 232
Lines 24534 24534
=========================================
Hits 21905 21905
Misses 2629 2629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The propel gen command when a table in schema.xml depends on a baseClass generates code
in the "Base" namespace that is not compatible with PHP 8.2.
For example, when saving the object, a deprecation warning is displayed:
Deprecated: Use of "self" in callables is deprecated in ... on line ...This is a known issue whith PHP8.2 :
https://php.watch/versions/8.2/partially-supported-callable-deprecation