Fix: handle NULL values in pg_settings.short_desc for Postgres Pro Enterprise#1235
Open
dimasikpower wants to merge 1 commit intoprometheus-community:masterfrom
Open
Conversation
- Added COALESCE(short_desc, '') to handle NULL values in pg_settings query - Fixes compatibility with Postgres Pro Enterprise 16.6+ - Resolves issue prometheus-community#1186
Contributor
|
This is failing on the DCO - you need to sign off on the commit |
|
Is there any update regarding this issue? We are experiencing the same issue too. |
Contributor
|
@dimasikpower Can you fix the DCO and rebase? I think it can be merged once that is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1186
Problem
Postgres Pro Enterprise 16.6 has NULL values in
pg_settings.short_descfor parameters:This causes exporter to crash with error: