Instantiate ValuesFrom before evaluating hash #1592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures valuesFrom resources are fully instantiated/templated before calculating the hash used for change detection.
When a Helm chart utilizes valuesFrom (referencing a ConfigMap or Secret) and those resources contain Sveltos templates, Sveltos was previously calculating the hash based on the raw resource content rather than the instantiated content.
Example Scenario: A ConfigMap is used in valuesFrom with template annotations:
If the Cluster annotation
rolechanged, the ConfigMap content itself remained the same (the template string didn't change), causing Sveltos to erroneously conclude that the Helm values were unchanged. Consequently, the Helm release was not updated to reflect the new metadata.This was visible in the ClusterSummary Status.HelmReleaseSummaries valuesHash not changing:
This PR modifies the evaluation logic to:
This ensures that any change in the underlying data (like Cluster metadata or referenced Secrets) changing the helm values, correctly triggers a Helm reconciliation.
Fixes #1591