🛡️ Sentinel: [HIGH] Fix XSS vulnerability in location message parsing#766
🛡️ Sentinel: [HIGH] Fix XSS vulnerability in location message parsing#766kevinaboos wants to merge 1 commit intomainfrom
Conversation
**Vulnerability:** A Cross-Site Scripting (XSS) vulnerability existed when parsing location messages. User-provided location coordinates (`lat`, `long`), URI (`geo_uri`), and fallback body (`body`) were directly interpolated into an HTML string using `format!` without any sanitization or escaping. **Impact:** A malicious user could send a location message containing crafted coordinates or URIs that break out of the HTML `href` attribute to inject arbitrary HTML or JavaScript, resulting in XSS when the victim viewed the message. **Fix:** Wrapped the untrusted inputs using the `htmlize` crate before using them in the HTML template. Used `htmlize::escape_attribute` for attribute contexts (e.g. `href`) and `htmlize::escape_text` for tag body contexts. Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Cross-Site Scripting (XSS) during HTML construction for Matrix Location messages.
🎯 Impact: Malicious users could inject arbitrary HTML/JavaScript into the victim's UI.
🔧 Fix: Properly sanitized
geo_uri,lat,long,short_lat,short_long, andlocation.bodyusing thehtmlizecrate (escape_attributeandescape_text) before formatting the location HTML block.✅ Verification: Verified that location message strings are correctly escaped and tests (
cargo test) and linters (cargo check) pass.PR created automatically by Jules for task 11915613457151741010 started by @kevinaboos