[NCL-9535]: Slsa Provenance has invalid digest key (commit); add a schema validator to verify provenance compliance#4455
Closed
vibe13 wants to merge 3 commits intoproject-ncl:v3.4.xfrom
Closed
[NCL-9535]: Slsa Provenance has invalid digest key (commit); add a schema validator to verify provenance compliance#4455vibe13 wants to merge 3 commits intoproject-ncl:v3.4.xfrom
vibe13 wants to merge 3 commits intoproject-ncl:v3.4.xfrom
Conversation
…hema validator to verify provenance compliance
REST API CHANGED |
michalovjan
requested changes
Feb 5, 2026
Contributor
|
retest this please |
michalovjan
requested changes
Feb 5, 2026
Contributor
michalovjan
left a comment
michalovjan
left a comment
There was a problem hiding this comment.
Didn't you also want to change the PROVENANCE_V1_SCM_COMMIT value from commit to gitCommit?
Contributor
Author
Yes, this is done in https://github.com/project-ncl/pnc/pull/4455/changes#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R112 and project-ncl/pnc-api@312d518 |
Contributor
Ah, missed that. |
Contributor
Author
|
Closing this, and porting fixes in #4456 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.