[NCL-9428] add endpoint for importing builds by michalovjan · Pull Request #4441 · project-ncl/pnc

michalovjan · 2026-01-23T14:10:11Z

Checklist:

Have you added unit tests for your change?

github-actions · 2026-01-23T14:10:27Z

REST API CHANGED

==========================================================================
==                            API CHANGE LOG                            ==
==========================================================================
                                   PNC                                    
--------------------------------------------------------------------------
--                              What's New                              --
--------------------------------------------------------------------------
- GET    /attachments
- POST   /attachments
- GET    /attachments/{id}
- PUT    /attachments/{id}
- GET    /builds/{id}/attachments

--------------------------------------------------------------------------
--                            What's Deleted                            --
--------------------------------------------------------------------------
- GET    /builds/{id}/artifacts/attachments

--------------------------------------------------------------------------
--                            What's Changed                            --
--------------------------------------------------------------------------
- GET    /environments/{id}
  Operation ID:
    - Changed getSpecific_4 to getSpecific_5
- GET    /scm-repositories/{id}
  Operation ID:
    - Changed getSpecific_12 to getSpecific_13
- PUT    /scm-repositories/{id}
  Operation ID:
    - Changed update_9 to update_10
- GET    /target-repositories/{id}
  Operation ID:
    - Changed getSpecific_13 to getSpecific_14
- GET    /build-configs/{id}
  Operation ID:
    - Changed getSpecific_1 to getSpecific_2
- PUT    /build-configs/{id}
  Operation ID:
    - Changed update_1 to update_2
- GET    /builds/{id}
  Operation ID:
    - Changed getSpecific_2 to getSpecific_3
- PUT    /builds/{id}
  Operation ID:
    - Changed update_2 to update_3
- GET    /deliverable-analyses/{id}
  Operation ID:
    - Changed getSpecific_3 to getSpecific_4
- GET    /environments
  Operation ID:
    - Changed getAll_4 to getAll_5
- GET    /group-builds/{id}
  Operation ID:
    - Changed getSpecific_5 to getSpecific_6
- GET    /group-configs/{id}
  Operation ID:
    - Changed getSpecific_6 to getSpecific_7
- PUT    /group-configs/{id}
  Operation ID:
    - Changed update_3 to update_4
- GET    /product-milestones/{id}
  Operation ID:
    - Changed getSpecific_8 to getSpecific_9
- PUT    /product-milestones/{id}
  Operation ID:
    - Changed update_5 to update_6
- GET    /product-releases/{id}
  Operation ID:
    - Changed getSpecific_9 to getSpecific_10
- PUT    /product-releases/{id}
  Operation ID:
    - Changed update_6 to update_7
- GET    /product-versions/{id}
  Operation ID:
    - Changed getSpecific_10 to getSpecific_11
- PUT    /product-versions/{id}
  Operation ID:
    - Changed update_7 to update_8
- GET    /products/{id}
  Operation ID:
    - Changed getSpecific_7 to getSpecific_8
- PUT    /products/{id}
  Operation ID:
    - Changed update_4 to update_5
- GET    /projects/{id}
  Operation ID:
    - Changed getSpecific_11 to getSpecific_12
- PUT    /projects/{id}
  Operation ID:
    - Changed update_8 to update_9
- GET    /scm-repositories
  Operation ID:
    - Changed getAll_9 to getAll_10
- GET    /target-repositories
  Operation ID:
    - Changed getAll_10 to getAll_11
- GET    /artifacts/purl/{purl}
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /artifacts/{id}
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- PUT    /artifacts/{id}
  Request:
        - Changed application/json
          Schema: Broken compatibility
          Missing property: attachedBuild (object)
- GET    /build-configs
  Operation ID:
    - Changed getAll_1 to getAll_2
- GET    /builds
  Operation ID:
    - Changed getAll_2 to getAll_3
- GET    /deliverable-analyses
  Operation ID:
    - Changed getAll_3 to getAll_4
- GET    /group-builds
  Operation ID:
    - Changed getAll_5 to getAll_6
- GET    /group-configs
  Operation ID:
    - Changed getAll_6 to getAll_7
- GET    /products
  Operation ID:
    - Changed getAll_7 to getAll_8
- GET    /projects
  Operation ID:
    - Changed getAll_8 to getAll_9
- POST   /artifacts
  Request:
        - Changed application/json
          Schema: Broken compatibility
          Missing property: attachedBuild (object)
  Return Type:
    - Changed 201 Created
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /artifacts
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /builds/{id}/artifacts/built
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- PUT    /builds/{id}/artifacts/built
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- POST   /builds/{id}/artifacts/built/quality
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /builds/{id}/artifacts/dependencies
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- PUT    /builds/{id}/artifacts/dependencies
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /product-milestones/delivered-artifacts/shared
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /product-milestones/{id}/delivered-artifacts
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /target-repositories/{id}/artifacts
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
- GET    /deliverable-analyses/{id}/analyzed-artifacts
  Return Type:
    - Changed 200 OK
      Media types:
        - Changed application/json
          Schema: Backward compatible
--------------------------------------------------------------------------
--                                Result                                --
--------------------------------------------------------------------------
                 API changes broke backward compatibility                 
--------------------------------------------------------------------------

michalovjan · 2026-01-26T09:23:49Z

retest this please

michalovjan · 2026-01-28T18:27:49Z

retest this please

michalovjan · 2026-01-30T12:31:15Z

retest this please

michalovjan · 2026-01-30T12:51:18Z

@jomrazek
these are broken because I've added more validation to Artifact DTO

- PUT    /artifacts/{id}
  Request:
        - Changed application/json
          Schema: Broken compatibility
- POST   /artifacts
  Request:
        - Changed application/json
          Schema: Broken compatibility

michalovjan · 2026-02-16T12:51:31Z

retest this please

This reverts commit c020d34. # Conflicts: # rest/src/main/java/org/jboss/pnc/rest/endpoints/internal/BuildTaskEndpointImpl.java

jomrazek

looks good 🤕

michalovjan requested a review from matejonnet January 23, 2026 14:10

michalovjan force-pushed the NCL-9428-import-build branch from 472f58b to 57e4804 Compare January 23, 2026 14:12

matejonnet reviewed Jan 29, 2026

View reviewed changes

Comment thread ...-api-internal/src/main/java/org/jboss/pnc/rest/endpoints/internal/api/BuildTaskEndpoint.java Outdated

michalovjan force-pushed the NCL-9428-import-build branch from 57e4804 to 829adda Compare January 30, 2026 12:09

michalovjan requested a review from jomrazek January 30, 2026 12:15

michalovjan force-pushed the NCL-9428-import-build branch from 829adda to a686c46 Compare February 16, 2026 11:48

michalovjan force-pushed the NCL-9428-import-build branch from a686c46 to e2f15e1 Compare February 16, 2026 13:00

michalovjan added 12 commits February 16, 2026 14:04

[NCL-9428] add validation for import endpoint

4382cb3

improve validation message

8b7364f

[NCL-9428] fix ArtifactProviderTest tests after stricter constraints

575dcd8

[NCL-9428] add BuildMetaMapper

146623d

[NCL-9428] fix storing FAILED results when no subresult specified

3239eda

[NCL-9428] add api for import endpoint

5332ded

[NCL-9428] implement import endpoint

2715f12

remove jboss-snapshots

3908200

remove unused profile in rest/pom.xml

c4abc92

[NCL-9428] rename the build import endpoint

f3d95fa

[NCL-9428] add further validation to import endpoint

93f1efe

[NCL-9248] fix user being required in BuildExecutionConfiguration

f537411

michalovjan force-pushed the NCL-9428-import-build branch from e2f15e1 to 2591156 Compare February 16, 2026 13:04

michalovjan added 4 commits February 16, 2026 15:16

[NCL-9248] cover with tests

1f52407

Revert "[NCL-9404] introduce attachedArtifacts to BuildRecord model"

09c183b

This reverts commit c020d34. # Conflicts: # rest/src/main/java/org/jboss/pnc/rest/endpoints/internal/BuildTaskEndpointImpl.java

readability improvement in EndpointHelper

63cd0d5

fix using old build-coordinator's beans

9ca8b31

michalovjan added 2 commits February 16, 2026 15:16

update to pnc-api 3.5.0-SNAPSHOT

8dd5088

[NCL-9428][attachments] add new Attachment model

a23e464

michalovjan force-pushed the NCL-9428-import-build branch from 2591156 to 276bb36 Compare February 16, 2026 14:16

michalovjan added 5 commits February 17, 2026 11:08

[attachments] implement CRUD operations

1a67fad

[attachments] add /builds/{id}/attachments endpoint

324454c

[attachments] add and store attachments when build completes

fa9c72d

[attachments] clean attachments on temporary build removal

077a186

[attachments] send UMB event on a new attachment

d403940

michalovjan force-pushed the NCL-9428-import-build branch from 276bb36 to d403940 Compare February 17, 2026 10:08

michalovjan added 3 commits February 17, 2026 17:36

[attachments] add SQL migration script and forgotten UniqueConstraint

7e7a6bb

reduce verbosity of EAP startup logs

40eb8d6

add Attachment to test persistence.xml

2205201

jomrazek approved these changes Feb 24, 2026

View reviewed changes

michalovjan merged commit cc29bbf into project-ncl:master Feb 25, 2026
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NCL-9428] add endpoint for importing builds#4441

[NCL-9428] add endpoint for importing builds#4441
michalovjan merged 26 commits intoproject-ncl:masterfrom
michalovjan:NCL-9428-import-build

michalovjan commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

michalovjan commented Jan 26, 2026

Uh oh!

michalovjan commented Jan 28, 2026

Uh oh!

Uh oh!

michalovjan commented Jan 30, 2026

Uh oh!

michalovjan commented Jan 30, 2026

Uh oh!

michalovjan commented Feb 16, 2026

Uh oh!

jomrazek left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

michalovjan commented Jan 23, 2026

Checklist:

Uh oh!

github-actions bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

REST API CHANGED

Uh oh!

michalovjan commented Jan 26, 2026

Uh oh!

michalovjan commented Jan 28, 2026

Uh oh!

Uh oh!

michalovjan commented Jan 30, 2026

Uh oh!

michalovjan commented Jan 30, 2026

Uh oh!

michalovjan commented Feb 16, 2026

Uh oh!

jomrazek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 23, 2026 •

edited

Loading