fstar2: use KRML_EXE instead of KRML_HOME#276
Open
tahina-pro wants to merge 9 commits intoproject-everest:fstar2from
Open
fstar2: use KRML_EXE instead of KRML_HOME#276tahina-pro wants to merge 9 commits intoproject-everest:fstar2from
tahina-pro wants to merge 9 commits intoproject-everest:fstar2from
Conversation
Member
Member
|
The test stage failed with but that seems unrelated, karamel seems to be picked up and run correctly |
f3431a3 to
5a52a9b
Compare
Member
Author
5a52a9b should fix that issue. Could you please try again? Thanks in advance! |
…aramana_fstar2_krml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relies on the Karamel submodule from FStarLang/FStar#4161 not merged into Karamel master yet.
It replaces all uses of
KRML_HOMEwithKRML_EXE(and so it renamesEVERPARSE_USE_KRML_HOMEintoEVERPARSE_USE_KRML_EXE), leveraging FStarLang/karamel#701.In particular, it builds krmllib for the LowParse and QuackyDucky tests (they are the ones not using
krml -skip-linking)@mtzguido , could you please try using this branch with a new nightly
check-worldon F*? Thanks in advance!