Skip to content

Address terminal review #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cpuguy83 wants to merge 7 commits into
base: main
Choose a base branch
from

tests: treat timeout as a best effort instead of hard failure

2eeb01c
Select commit
Loading
Failed to load commit list.
Draft

Address terminal review #52

tests: treat timeout as a best effort instead of hard failure
2eeb01c
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO succeeded Jan 16, 2026 in 1s

Check passed!

All commits are signed off, the check passed.

Summary


Sha Message Pass or fail reason
🟢 cdff0cb Reduce chance of possible race in reusing terminal... Valid sign-off found
🟢 dc8302b Better handle name parameter in getOrCreateTermina... Valid sign-off found
🟢 647cee2 Add doc string to getBuildTerminalName Valid sign-off found
🟢 7e62e1e Harden build terminal reuse and cleanup Valid sign-off found
🟢 e178972 Tighten terminal helper tests Valid sign-off found
🟢 bee640c tests: make terminal names more unique Valid sign-off found
🟢 2eeb01c tests: treat timeout as a best effort instead of h... Valid sign-off found
View more details on DCO-2