version placeholder/parsing, and os targets by davidgamero · Pull Request #1 · project-dalec/dalec-docker-desktop-extension

davidgamero · 2026-01-20T19:09:15Z

add placeholder to version demonstrating format >=1.0.0, <2.0.0
add validation and parsing for version range lists
add list of supported os targets

davidgamero · 2026-01-20T19:09:55Z

copying @cpuguy83 comment here for reference

This is something that should be queried.
Example call:

docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest -<<<"{}"

Signed-off-by: David Gamero <david340804@gmail.com>

- Add test target to Makefile to run backend and UI tests - Configure vitest to run once and exit with --run flag - Add GitHub Actions workflow to run tests on push/PR - Refactor App.jsx to use clear variable names and if statements Signed-off-by: David Gamero <david340804@gmail.com>

davidgamero · 2026-01-20T22:39:05Z

big diff line count, but mostly package lock and tests

.github/workflows/test.yml

Signed-off-by: David Gamero <david340804@gmail.com>

Tatsinnit · 2026-01-23T17:24:42Z

Gentle fyi @yolossn 🥂☕️

Copilot

Pull request overview

Adds version-constraint parsing and OS-target discovery to improve Dalec build UX, plus introduces Vitest-based test coverage and a CI workflow.

Changes:

Add parseVersionConstraints() utility (with Vitest tests) and update UI to emit version constraint arrays in the command preview + update version placeholder.
Replace UI OS list handling with /api/os-backed OS targets plus a fallback list.
Add Vitest + make test support for UI/backend and a GitHub Actions workflow to run tests on PRs/pushes.

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ui/src/utils/versionParser.js	New utility to split/normalize comma-separated version constraints.
ui/src/utils/versionParser.test.js	Adds Vitest coverage for version constraint parsing.
ui/src/App.jsx	Uses the parser for command preview dependency spec; fetches OS targets from backend; updates UI placeholder.
ui/package.json	Adds Vitest scripts and devDependencies.
ui/package-lock.json	Locks newly added Vitest-related dependencies.
backend/src/osProvider.js	Switches OS discovery to docker buildx targets JSON with fallback list.
backend/src/osProvider.test.js	Adds Vitest coverage for OS target parsing/fallback behavior.
backend/package.json	Adds Vitest test script and devDependency.
backend/package-lock.json	Locks newly added Vitest-related dependencies.
Makefile	Adds `make test` to run backend+ui test suites.
.github/workflows/test.yml	Adds CI workflow to run `make test` on PRs/pushes.

Files not reviewed (2)

backend/package-lock.json: Language not supported
ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T17:29:15Z

ui/src/App.jsx

  const [imageName, setImageName] = useState('my-minimal-image:0.1.0');
+  const [osTargets, setOsTargets] = useState(OS_TARGETS);
  const [osTarget, setOsTarget] = useState('azlinux3');


osTarget is initialized to azlinux3 and never reconciled with the fetched osTargets list. If /api/os returns a list that doesn't include the current osTarget, MUI Select will have an out-of-range value and the generated build target/command can be invalid. Consider updating osTarget after fetching (or whenever osTargets changes) to ensure it always matches an available option (e.g., first element / fallback).

Copilot · 2026-01-23T17:29:16Z

Makefile

+test: ## Run tests for backend and UI
+	cd backend && npm test
+	cd ui && npm test


This test target should be declared phony (e.g., added to .PHONY) to avoid being skipped if a file named test exists in the repo.

Copilot · 2026-01-23T17:29:16Z

ui/src/utils/versionParser.test.js

+  });
+
+  it('preserves quotes inside constraint values', () => {
+    expect(parseVersionConstraints('>=1.0.0')).toEqual(['>=1.0.0']);


The test name "preserves quotes inside constraint values" doesn't match what the assertion checks (it doesn't include any quotes inside the constraint). Rename the test to reflect the actual behavior under test or update the input/assertion to cover quoted content.

Suggested change

expect(parseVersionConstraints('>=1.0.0')).toEqual(['>=1.0.0']);

expect(parseVersionConstraints('>=1."0".0, <2.\'0\'.0')).toEqual(['>=1."0".0', "<2.'0'.0"]);

Copilot · 2026-01-23T17:29:17Z

backend/src/osProvider.js

 export function fetchOsList() {
  return new Promise((resolve) => {
-    exec('dalec os list', { timeout: 5000 }, (err, stdout) => {
+    const cmd = 'docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest -<<<"\\{\\}"';


The cmd here-string currently passes \{\} (i.e., literal backslashes) to bash, which results in \{\} being sent to buildx rather than a valid {} JSON object. That likely makes the buildx call fail and forces fallback every time; pass a real {} (or use a safer stdin pipe) so dynamic target detection works as intended.

Suggested change

const cmd = 'docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest -<<<"\\{\\}"';

const cmd = 'docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest -<<<"{}"';

I think we can list the supported OS from the frontend itself using the ddClient. Please refer the usage here

dalec-docker-desktop-extension/ui/src/App.jsx

Line 284 in 182b6ed

const result = await ddClient.docker.cli.exec('image', [

I tried to do this a couple ways with the ddClient, but there was no support for stdin which was necessary for the os listing command. Do you have an idea how to do this without stndin?

You can provide a path to a file that's just {}

Equiv shell:

dir="$(mktemp -d)" echo '{}' > "${dir}/Dockerfile" docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest "${dir}"

oh i see, okay i'd still have to create the file from the backend right? frontend won't have write access to make a temp file?
i'll test it out now

Yeah, stdin is an issue here. I tried running this and the exec command in fetchOsList endpoint is failing with this error

frontend can't write files to disk even in tmp, so a viable pattern would be:

backend writes a temp file with "{}" as contents

pass that temp path to frontend via an api route?

frontend calls ddclient with command including the temp file path

davidgamero changed the title ~~verison placeholder~~ version placeholder Jan 20, 2026

davidgamero changed the title ~~version placeholder~~ version placeholder/parsing, and os targets Jan 20, 2026

verison placeholder

798a69e

Signed-off-by: David Gamero <david340804@gmail.com>

davidgamero force-pushed the david/version-placeholdr branch from fa4a103 to 798a69e Compare January 20, 2026 19:10

update os to fetch from dalec

d30a6cd

Signed-off-by: David Gamero <david340804@gmail.com>

davidgamero force-pushed the david/version-placeholdr branch from 2ff79d8 to d30a6cd Compare January 20, 2026 19:25

Tatsinnit approved these changes Jan 20, 2026

View reviewed changes

Tatsinnit requested a review from cpuguy83 January 20, 2026 21:24

Tatsinnit assigned davidgamero Jan 20, 2026

Tatsinnit added the enhancement New feature or request label Jan 20, 2026

os parse test

3736f3a

Signed-off-by: David Gamero <david340804@gmail.com>

davidgamero force-pushed the david/version-placeholdr branch from d6067d3 to e28a646 Compare January 20, 2026 22:36

davidgamero force-pushed the david/version-placeholdr branch from e28a646 to f8c7bf7 Compare January 20, 2026 22:37

Tatsinnit reviewed Jan 21, 2026

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

Tatsinnit reviewed Jan 21, 2026

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

edits

f596ecb

Signed-off-by: David Gamero <david340804@gmail.com>

Tatsinnit requested a review from Copilot January 23, 2026 17:25

Tatsinnit approved these changes Jan 23, 2026

View reviewed changes

Copilot started reviewing on behalf of Tatsinnit January 23, 2026 17:25 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

	expect(parseVersionConstraints('>=1.0.0')).toEqual(['>=1.0.0']);
	expect(parseVersionConstraints('>=1."0".0, <2.\'0\'.0')).toEqual(['>=1."0".0', "<2.'0'.0"]);

	const cmd = 'docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest -<<<"\\{\\}"';
	const cmd = 'docker buildx build --call targets,format=json --build-arg BUILDKIT_SYNTAX=ghcr.io/project-dalec/dalec/frontend:latest -<<<"{}"';

Conversation

davidgamero commented Jan 20, 2026

Uh oh!

davidgamero commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidgamero commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Tatsinnit commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

yolossn Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

davidgamero Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

cpuguy83 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

davidgamero Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

yolossn Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

davidgamero Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davidgamero commented Jan 20, 2026 •

edited

Loading