chore: Make update compliant for bash<4#2679
Open
glemaitre wants to merge 2 commits intoprobabl-ai:mainfrom
Open
chore: Make update compliant for bash<4#2679glemaitre wants to merge 2 commits intoprobabl-ai:mainfrom
glemaitre wants to merge 2 commits intoprobabl-ai:mainfrom
Conversation
glemaitre
commented
Mar 27, 2026
glemaitre
commented
Mar 27, 2026
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
thomass-dev
requested changes
Mar 27, 2026
Collaborator
thomass-dev
left a comment
thomass-dev
left a comment
There was a problem hiding this comment.
Let me test and review :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current file uses
mapfilesthat is only available for bash 4 while MacOS has only bash 3.2We can then avoid to use this function.