feat: accept metric names without neg_ prefix in summarize()#2656
Open
direkkakkar319-ops wants to merge 9 commits intoprobabl-ai:mainfrom
Open
feat: accept metric names without neg_ prefix in summarize()#2656direkkakkar319-ops wants to merge 9 commits intoprobabl-ai:mainfrom
neg_ prefix in summarize()#2656direkkakkar319-ops wants to merge 9 commits intoprobabl-ai:mainfrom
Conversation
This reverts commit 91fe125.
…est_metric_aliases.py`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2607
When using
report.metrics.summarize(), passing error metric names without theneg_prefix (e.g."mean_squared_error") would raise aValueErrorbecause sklearn's scorer registry only knows theneg_.Root Cause
Sklearn follows a "higher is better" convention for all scorers.
Error metrics like
mean_squared_errorare therefore only registered asneg_mean_squared_errorin sklearn's scorer registry.Solution
Added a
_METRIC_ALIASESdictionary inside_MetricsAccessorthat maps user-friendly metric names to theirneg_prefixed sklearn scorer equivalents.Changes
skore/src/skore/_sklearn/_estimator/metrics_accessor.py— added_METRIC_ALIASESdict and resolution logic insummarize()skore/src/skore/_sklearn/_estimator/metrics_accessor.pymade this code
to
skore/tests/unit/reports/estimator/metrics/test_metric_aliases.py— added test cases for the fixsphinx/changelog.rst— updated changelogTesting