fix(skore): Do not start matplotlib GUI in non-main thread#2459
Draft
glemaitre wants to merge 1 commit intoprobabl-ai:mainfrom
Draft
fix(skore): Do not start matplotlib GUI in non-main thread#2459glemaitre wants to merge 1 commit intoprobabl-ai:mainfrom
glemaitre wants to merge 1 commit intoprobabl-ai:mainfrom
Conversation
Collaborator
Contributor
Contributor
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

related #2409
When putting in parallel, we trigger Matplotlib GUI outside of the main thread which seems to be tricky.
Here,
plt.tight_layoutis triggering such behaviour.However, it does not address all the problem detected in #2409. Indeed, because we are using seaborn that call
plt.figure, then the Matplotlib GUI is called from outside skore. The solution, would be to switch to a non-interactive backend.But we end-up in the same issue pointed out by @thomass-dev. I assume that putting object in parallel will have exactly the same problem. So while using
plt.ioffto deactivate the interactive mode allowing to not break matplotlib in a notebook, this solution does not solve really the problem of the backend.So we might finally need to find a way to switch the plotting backend even once
matplotlibhas been imported because we don't have the hand on whatseabornis doing.