fix: resolve tsconfig path aliases containing a colon#780
Open
msmx-mnakagawa wants to merge 1 commit intoprivatenumber:masterfrom
Open
fix: resolve tsconfig path aliases containing a colon#780msmx-mnakagawa wants to merge 1 commit intoprivatenumber:masterfrom
msmx-mnakagawa wants to merge 1 commit intoprivatenumber:masterfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #730
Root cause
resolveTsPaths(ESM hook) gatestsconfigPathsMatcherbehind!requestAcceptsQuery(specifier).requestAcceptsQueryreturnstruefor any specifier containing:— treating it as a URL scheme — so aliases likens:somethingbypass path resolution and are passed raw to Node's ESM loader, which rejects the unknown scheme.The CJS equivalent uses
!isFilePath(request)and is unaffected.Fix
Replace
!requestAcceptsQuery(specifier)with!isFilePath(specifier) && !specifier.startsWith(fileUrlPrefix), mirroring the CJS check.The
fileUrlPrefixguard is ESM-specific:file://specifiers may arrive in the ESM hook directly, whereas CJS pre-converts them to file paths before this point.