feat: Make kill-timeout configurable#769
Open
CommanderRedYT wants to merge 2 commits intoprivatenumber:masterfrom
Open
feat: Make kill-timeout configurable#769CommanderRedYT wants to merge 2 commits intoprivatenumber:masterfrom
CommanderRedYT wants to merge 2 commits intoprivatenumber:masterfrom
Conversation
|
As mentioned in #469 this would be super helpful 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I thought about this
My application registers custom handlers with calls like
process.on('SIGINT'). In there, I am waiting to gracefully shutdown another process. This takes some time, sometimes more than 5 seconds. The idea is to have this configurable so that noSIGKILLis sent that breaks saving in the childprocess.Description
This PR implements a new flag
--kill-timeout <number>for thewatchsubcommand. The number is used in the timeout to change and possibly extend the grace period until the process is killed after sending the SIGINT.I am happy to implement any feedback provided.