Fix #8449: Nested SplitterPanel detection logic#8448
Fix #8449: Nested SplitterPanel detection logic#8448melloware merged 3 commits intoprimefaces:masterfrom
Conversation
Current logic incorrectly identifies any nested Prime Component as a nested SplitterPanel causing incorrect behaviour. This change fixes that to identify SplitterPanel component only for such purpose.
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
1 similar comment
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
I'm unable to link this with the PR. The instructions in github don't work for some reason. But I've updated the title, hope that should do |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Please run |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
@melloware I've pushed a fix for formatting, but it's failing still for a different file I did not change. Would you like me to fix that as well and push? |
|
Yes please let's get the build passing |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
It's still failing for the linked issue, not sure why. Is this something you can check? |
|
yeah that is flaky. Running the build now. |
Current logic incorrectly identifies any nested Prime Component as a nested SplitterPanel causing incorrect behaviour. This change fixes that to identify SplitterPanel component only for such purpose.
Fix: #8449