Conversation
* Since version 10.3.0, a condition has been added to prevent submenus from activating on hover when in “popup” mode (commit 5615c89). I don't really understand why this constraint exists. But removing it resolves issue primefaces#5975 and aligns with PrimeVue's behaviour. * little format fix in Slider.js
Member
|
@kyybo did you look at Git Blame and see when and why that line was changed? |
Contributor
Author
|
Yes, as I said in my commit message, this line appeared since the commit 5615c89 When we look at PrimeVue code, there is only the condition on the |
Member
|
OK run |
revert from commit b435248 I ran the command "npm run format", but my version of Prettier was not up to date, my bad.
melloware
added
the
Type: Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 10.3.0, a condition has been added to prevent submenus from activating on hover when in “popup” mode (commit 5615c89). I don't really understand why this constraint exists. But removing it resolves issue TieredMenu: Submenu 'popup' behavior different than PrimeVue #5975 and aligns with PrimeVue's behaviour.
little format fix in Slider.js
Fix #5975