#8318 Fix the showHeader default value of Editor#8319
Merged
melloware merged 2 commits intoprimefaces:masterfrom Oct 6, 2025
Merged
#8318 Fix the showHeader default value of Editor#8319melloware merged 2 commits intoprimefaces:masterfrom
melloware merged 2 commits intoprimefaces:masterfrom
Conversation
Member
|
@yunics-highfield you need to change it here: primereact/components/lib/editor/editor.d.ts Line 140 in 05c7611 the docs are driven from the TypeScript and the TypeScript has it incorrect! Update your PR and I will merge. |
melloware
added
Type: Bug
melloware
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8318
It's true actually.
primereact/components/lib/editor/EditorBase.js
Line 1084 in ea77943