fix #8272: bug in onSpaceKey with shift selection in PickList#8273
Merged
melloware merged 3 commits intoprimefaces:masterfrom Sep 8, 2025
emmanuel-ferdman:master
Merged
fix #8272: bug in onSpaceKey with shift selection in PickList#8273melloware merged 3 commits intoprimefaces:masterfrom emmanuel-ferdman:master
melloware merged 3 commits intoprimefaces:masterfrom
emmanuel-ferdman:master
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Member
|
I think you need to run |
Contributor
Author
|
@melloware I did ran |
Member
|
yes please! |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
Author
|
@melloware sure, updated. thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8272.
PR Summary
This small PR handles a bug in onSpaceKey with shift selection in PickList.
Steps to reproduce the behavior
I have prepared a minimal demo:
It will fail with runtime errors.