fix: #7527, Dropdown: Editable Dropdown search not working as expected#7528
Merged
melloware merged 1 commit intoprimefaces:masterfrom Dec 26, 2024
Merged
fix: #7527, Dropdown: Editable Dropdown search not working as expected#7528melloware merged 1 commit intoprimefaces:masterfrom
melloware merged 1 commit intoprimefaces:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
melloware
requested changes
Dec 26, 2024
| if (exactMatch !== -1) return exactMatch; | ||
|
|
||
| return visibleOptions.findIndex((item) => getOptionLabel(item).toLocaleLowerCase().startsWith(normalizedSearch)); | ||
| }; |
Member
There was a problem hiding this comment.
Won't this do it more efficientialy by only calling FindIndex 1 instead of passing over the whole array twice?
const search = (visibleOptions, searchText) => {
if (!searchText || !visibleOptions?.length) return -1;
const normalizedSearch = searchText.toLocaleLowerCase();
return visibleOptions.findIndex((item) => {
const label = getOptionLabel(item).toLocaleLowerCase();
return label === normalizedSearch || label.startsWith(normalizedSearch);
});
};I would also call the method search instead of findInArray
Member
There was a problem hiding this comment.
Oh no i see you want to search the whole list for an exact match before trying again with startswith
Contributor
Author
There was a problem hiding this comment.
Right, we will need to iterate the array twice in this case. Once to find the exact match and then to find matches with startsWith.
melloware
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #7527, Dropdown: Editable Dropdown search not working as expected
#7527