Fix issue 61 - #68
Open
sheldonwjones wants to merge 1 commit into
Open
Conversation
— make g:indent_guides_autocmds_enabled a buffer variable — this allows file type auto commands like (autocmd FileType python IndentGuidesEnable)
Collaborator
|
Thanks, will give it a test run shortly. |
|
+1 for this feature |
|
+1 for this feature as well |
|
👍 Any particular reason this has not been merged in yet? |
Collaborator
Unfortunately there was a reason, the feature broke some existing functionality and I haven't had time to look into fixing it. |
alerque
requested changes
Feb 21, 2023
alerque
left a comment
alerque
left a comment
Member
There was a problem hiding this comment.
This PR will need updating before merging. Changing the variable to a buffer local is just fine (and a good change) but the buffer local
variable should default to the value of the global setting variable if not otherwise set. That can be done once, then used later in the script as needed.
alerque
marked this pull request as draft
February 21, 2023 13:48
alerque
marked this pull request as ready for review
February 21, 2023 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— make g:indent_guides_autocmds_enabled a buffer variable
— this allows file type auto commands like (autocmd FileType python IndentGuidesEnable)