Mobile app rendering: if burl is missing from bid, write ad markup after MRAID-viewable#248
Open
rickyblaha wants to merge 2 commits intoprebid:masterfrom
Conversation
added 2 commits
December 19, 2024 02:27
… if there is a burl present. If no burl, render the markup only after mraid viewable happens. * Added console logs to observe this behavior that stick around in `window.pucLogs` so they can be viewed once a web view is inspected after render has already taken place. * Added simple MRAID 2 and 3 for use in the unit tests for this change.
|
@YuriyVelichkoPI - we should complete the review of this PR and the open measurement impression tracking PR for Mobile. |
Contributor
|
@ChrisHuie FYI |
|
discussed in PMC:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce discrepancies, when
burlis missing from mobile app bids, rendering of ad markup is now delayed until MRAID-viewable happens, so tracking pixels present in ad markup do not get called too soon.Included units tests along with a simple mock of MRAID 2 and MRAID 3 that has only enough features for these tests.
Also included a simple log function called during this rendering sequence to help with debugging. Once ad render already happens, you can use Safari Dev Tools to inspect the web view, go to the console and type
pucLogsto see all the console logs that happened prior to opening dev tools.