fix(protocol): re-run request-body filters on each upstream attempt - #1162
Open
Aman-Cool wants to merge 1 commit into
Open
fix(protocol): re-run request-body filters on each upstream attempt#1162Aman-Cool wants to merge 1 commit into
Aman-Cool wants to merge 1 commit into
Conversation
|
Unsigned commits: 7a7d878. Please sign your commits. |
Aman-Cool
force-pushed
the
fix/retry-rerun-request-body-filters
branch
from
September 12, 2026 18:13
282f87b to
66d90b7
Compare
body_done marks are per-request, so a filter that finished on one attempt was skipped on the next: the replayed body went upstream unfiltered under a Content-Length describing the rewritten one. Fixes praxis-proxy#1146 Signed-off-by: Aman-Cool <aman017102007@gmail.com>
Aman-Cool
force-pushed
the
fix/retry-rerun-request-body-filters
branch
from
September 12, 2026 18:58
66d90b7 to
04f2c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1146.
body_donemarks are per-request, so from the second retry onward therequest-body filters were skipped and the replayed body went upstream
unfiltered.., under a
Content-Lengththat still described the rewritten one.Clears the request-body marks per attempt in
upstream_request_filter, rightnext to
apply_mutated_content_length, so the two can't drift apart. Fullwrite-up of how it was found is in the issue.
Regression test covers shrinking and growing rewrites, a single retry, and a
ReadOnly control.
Checklist
git commit -s)make lint && make test && make test-integrationpasses locallyDoes this introduce a breaking change?
No.
FilterPipeline::clear_request_body_doneis additive.