Skip to content

Update ci.yml#1173

Closed
gogainda wants to merge 4 commits intoprawnpdf:masterfrom
gogainda:patch-2
Closed

Update ci.yml#1173
gogainda wants to merge 4 commits intoprawnpdf:masterfrom
gogainda:patch-2

Conversation

@gogainda
Copy link

@gogainda gogainda commented Sep 5, 2020

No description provided.

fail-fast: false
matrix:
image:
- ruby:2.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your enthusiasm about TruffleRuby but I'd like to keep our current set of rubies as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert it back, just want to skip all other ruvies for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Let me know when this PR is ready.

@gogainda
Copy link
Author

gogainda commented Sep 5, 2020

@pointlessone tests are passing, but rubocop fails due to a bug, so without upgrading rubocop to the 0.90 version truffleruby cannot be enabled right now

@gogainda
Copy link
Author

gogainda commented Sep 5, 2020

I tried to upgrade the rubocop version to 0.90 and it helped, but it introduced some failing checks which are part of newer version of rubocop.

@eregon
Copy link

eregon commented Oct 10, 2020

@gogainda Could you just skip RuboCop on TruffleRuby? (using a separate workflow which doesn't use container:).
It would be redundant anyway and just make the build slower.

@pointlessone
Copy link
Member

I tried adding truffleruby in the latest CI update and encountered some issues.

Specifically, build fails with truffleruby and the failure is some sort of error in Rubocop.

At the moment I don't see truffleruby feasible. Especially since there's no one on the team using it. We'll gladly accept help from someone who's willing to spend their time regularly fixing compatibility issues.

@eregon
Copy link

eregon commented Dec 30, 2020

Makes sense, I'll make a draft PR and try to get it working.
It would be valuable to test latest Prawn + TruffleRuby since it's a non-trivial codebase and actually all tests pass fine.

@eregon
Copy link

eregon commented Dec 30, 2020

#1189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants