Conversation
| fail-fast: false | ||
| matrix: | ||
| image: | ||
| - ruby:2.5.0 |
There was a problem hiding this comment.
I appreciate your enthusiasm about TruffleRuby but I'd like to keep our current set of rubies as well.
There was a problem hiding this comment.
I will revert it back, just want to skip all other ruvies for now
There was a problem hiding this comment.
OK. Let me know when this PR is ready.
|
@pointlessone tests are passing, but rubocop fails due to a bug, so without upgrading rubocop to the 0.90 version truffleruby cannot be enabled right now |
|
I tried to upgrade the rubocop version to 0.90 and it helped, but it introduced some failing checks which are part of newer version of rubocop. |
|
@gogainda Could you just skip RuboCop on TruffleRuby? (using a separate workflow which doesn't use |
|
I tried adding truffleruby in the latest CI update and encountered some issues. Specifically, build fails with truffleruby and the failure is some sort of error in Rubocop. At the moment I don't see truffleruby feasible. Especially since there's no one on the team using it. We'll gladly accept help from someone who's willing to spend their time regularly fixing compatibility issues. |
|
Makes sense, I'll make a draft PR and try to get it working. |
No description provided.