ci: onboard leaderboard backfill replay caller (ENG-5992) - #139
ci: onboard leaderboard backfill replay caller (ENG-5992)#139nsportsman wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 25 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
Claude Review
Critical issues
capability_mapomission may break the contract / mis-attribute. The live siblingleaderboard-metrics.ymlin this repo passescapability_map: '[{"path": ".", "name": "trajan"}]'explicitly. This new caller omits it, justified by the comment "unset means derive it from this repo's own live leaderboard-metrics.yml." But the live caller does not derive anything — it hardcodes the value — so "attributes capabilities exactly as live runs do" is unverifiable from this repo and inconsistent with the only sibling we can inspect. Ifleaderboard-backfill.yml@v2.17.0does not actually derive-from-live (no default, or a different derivation), replaying #136/#137 either fails at runtime or attributes capabilities differently than the live run. Please confirm against the reusable's actual input contract before merge; if in doubt, pass the same explicitcapability_mapthe live caller uses.- The
v2.17.0version comment on the pin is self-guarded byverify-pins.yml(fails CI on a dishonest tag-to-SHA mapping). Merge should be gated on that check going green rather than on the PR description's sha256 assertion.
Security
- This extends
id-token: write(OIDC AssumeRole) to a new external reusable (leaderboard-backfill.yml, v2.17.0) whose source is not in this repo and can't be reviewed here. It is the samepraetorian-inc/public-workflowsorg already trusted by the merged metrics caller, but a different reusable and a newer version — the whole trust boundary rests on the SHA pin + org control of that ref. Worth an explicit sign-off that v2.17.0 of the backfill reusable itself was reviewed, not merely that its SHA sits on the IAM trust list. - Trigger is
workflow_dispatch-only (requires write access) andpr_numbersflows only into a reusablewith:input, not arun:step here — no injection surface in this file, and no secrets in it.
Test coverage
Not applicable — pure GitHub Actions YAML, no *.go/*.ts/*.py production code.
Adjudication of automated review findingsClaude finding 1 — "capability_map omission may break the contract / mis-attribute": REFUTED. Claude finding 2 — "merge should be gated on verify-pins going green, not the PR description": CONFIRMED, and satisfied. Claude security note — "explicit sign-off that v2.17.0 of the backfill reusable itself was reviewed": answered. No fix commits needed — no finding survived confirmation as a defect. Merge remains a human decision. |
Summary
Onboards the operator-dispatched leaderboard backfill replay caller (ENG-5992, part of the ENG-5973 fleet-audit follow-up):
.github/workflows/leaderboard-backfill-caller.yml(new) — dispatch-only (workflow_dispatch) caller of theleaderboard-backfill.ymlreusable, replicated from the template already merged innervaandcaeruleus. Merging this enables replay; it never runs automatically, and no dispatch happens as part of this PR.This repo has no
.github/dependabot.yml, so no dependabot change is needed; the workflow header documents the ignore requirement should one ever be added.Why
The 2026-08-09 fleet audit found 2 replay-eligible PRs in this repo with no delivery run at all (#136, #137 — merged before onboarding). Replaying them requires this caller.
Do not bump the pin
uses: …leaderboard-backfill.yml@6c715ccf351a09bfcb916aede4c542e437e5f31d # v2.17.0is the exact SHA on the IAM trust list. Bumping it alone fails closed at AssumeRole with no local signal — a bump follows the ENG-4164 runbook (trust updated and deployed first).Gates
name:down verified byte-identical (sha256) to the live nerva/caeruleus canonical; actionlint clean; this repo'sverify-pins.ymlpasses on the SHA-pinneduses:.Ticket: ENG-5992 (blocks the ENG-5690 replay work).
🤖 Generated with Claude Code