fixed issued with the wrong weights being assigned to events.#60
Open
Walter-Ullon wants to merge 1 commit intopractical-recommender-systems:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Kim,
I have started going over the code and the simulated data and trying to replicate it all in python-pandas in a local repo to ensure I understand all the steps and can derive things on my own.
I have come across this issue where in the textbook, as well as line 58 of
implicit_rating_calculator.py, you designate"moredetails"asw2(50), but in line 93 you have it switched with"details".There's one other issue I will create a PR for once I find it, but in listing 4.1 of the textbook, you do a
count(CASE...usingmoredetailsas the event, when in fact in should bemoreDetails. This is causing the simulated data to contain all zeroes undermoreDetailswhen counting events for users. I have checked this locally and can confirm. This will skew all implicit ratings.Cheers!