Merged
Conversation
Member
|
Seems like there's pixel shift left of all flags, not sure if we want to care about that. 2025-07-08.21.26.35.mp4 |
Collaborator
Author
|
Yeah I noticed and decided I don't care to chase this down to be honest with you. |
Member
|
For my future self: osu-web is using the discord package of twemoji which differs in no meaningful way from the one in this change. |
peppy
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for doing this is a complaint that the Syrian flag (
SY.png) is out of date. I think there are a few other changed flags but unfortunately the toolchain used to generate these is not binary-output-stable so it's not possible to determine that from the diff and I'm not checking 250 flags by hand.Script needed some updates because nothing ever stays still in this business.
Notably because original twemoji upstream is very dead for known reasons this uses a fork (https://github.com/jdecked/twemoji).