Conversation
leonardoalt
reviewed
Jan 5, 2026
| path: | | ||
| tests_cpu.tar.zst | ||
| - name: Create tests archive (GPU) | ||
| run: cargo nextest archive --archive-file tests_gpu.tar.zst --cargo-profile pr-tests --workspace --features cuda |
Member
There was a problem hiding this comment.
isn't this needed by build itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of building once on a CPU runner and once on a GPU runner, we can build once on a runner that allows both (basically a GPU runner) and upload the test artifact with different feature flags for both CPU and GPU test runs.
Currently all tests panic on this in OVM:
I think this error might happen because
manifest_diris different between our self-hosted GPU server and the warp runners. Previously both CPU build and CPU test run happen on warp runner, but now CPU build happens on self-hosted server while CPU test run on warp runner.Probably need to wait for setting up some warp runners to test this again.