decouple copilot completions from copilot chat (#14764)#14794
Merged
Conversation
) Closes #14369 - ensures copilot completions are properly gated behind `ai.enabled` - confirms copilot completions are still enabled even when `chat.disableAIFeatures` is true - confirms copilot completions are disabled only with `ai.enabled = false` or `github.copilot.enable = { "*": false }`, or when github copilot is not auth'd with the provider modal - updates the `chat.disableAIFeatures` setting description to be more clear how it affects copilot chat and completions - <img width="428" height="97" alt="image" src="https://github.com/user-attachments/assets/9a5f4e63-f96d-4445-8b4d-de7df93776d4" /> - keep status bar icon visible by default, but don't show chat info unless copilot chat is enabled - completions available and enabled - <img width="249" height="160" alt="image" src="https://github.com/user-attachments/assets/870b190e-3676-4315-9a9b-4a0d829bd502" /> - not auth'd with github - <img width="171" height="91" alt="image" src="https://github.com/user-attachments/assets/0bdc95cc-e7c3-4a39-aed9-1d7874ff724b" /> - `chat.disableAIFeatures = false` + not auth'd with github - <img width="198" height="212" alt="image" src="https://github.com/user-attachments/assets/66217848-c6f6-48cd-a72c-11094fdfc851" /> - `chat.disableAIFeatures = false` + auth'd with github - <img width="249" height="225" alt="image" src="https://github.com/user-attachments/assets/7c4eeed8-4200-4f08-b535-4ec0f2acbca4" /> - status bar icon updates when `ai.enabled` and `chat.disableAIFeatures` change, without having to reload - `isCompletionsOnlyMode` indicates the default state where `chat.disableAIFeatures = true`, so only completions are applicable to the chat status - adds vitest coverage for `isCompletionsOnlyMode` (ai.enabled off, `chat.disableAIFeatures = true`, `chat.disableAIFeatures = false`) and for the `ai.enabled` gate in `isCompletionsEnabled` - adds a regression check that flipping chat.disableAIFeatures doesn't change inline completions - to use github copilot in positron for AI features, you must authenticate using the provider modal - Show GitHub Copilot completions status icon by default (#14369) some cases - when `ai.enabled` is true, the status icon should not be present - regardless of `chat.disableAIFeatures`, the status icon should be present - see above screenshots for how the status bar popup should look with different settings configurations --------- Co-authored-by: sharon wang <25834218+sharon-wang@users.noreply.github.com>
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. |
they are flaky
Contributor
|
@sharon-wang - can you add a proper mapping (or |
Member
Author
sharon-wang
added a commit
that referenced
this pull request
Jul 9, 2026
test/e2e/tests/assistant/copilot-provider-disabled-status.test.ts is new as of #14764 but it is flaking on web the copilot extension flakily doesn't activate in our web tests, so let's just not run the copilot e2e tests on web @:assistant also made this change to #14794 Co-authored-by: sharon wang <25834218+sharon-wang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #14764 to main. Resolved some merge conflicts arising from changed upstream completions and auth related code, as well as some minor test fixes.
Closes #14369
ai.enabledchat.disableAIFeaturesis trueai.enabled = falseorgithub.copilot.enable = { "*": false }, or when github copilot is not auth'd with the provider modalchat.disableAIFeaturessetting description to be more clear how it affects copilot chat and completionschat.disableAIFeatures = false+ not auth'd with githubchat.disableAIFeatures = false+ auth'd with githubai.enabledandchat.disableAIFeatureschange, without having to reloadisCompletionsOnlyModeindicates the default state wherechat.disableAIFeatures = true, so only completions are applicable to the chat statusisCompletionsOnlyMode(ai.enabled off,chat.disableAIFeatures = true,chat.disableAIFeatures = false) and for theai.enabledgate inisCompletionsEnabledRelease Notes
Bug Fixes
Validation Steps
some cases
ai.enabledis true, the status icon should not be presentchat.disableAIFeatures, the status icon should be presentWhat to test
@:assistant
github auth behaviour
github provider enablement behaviour