fix: Skip statistics deserialization for Null columns in Parquet#27021
Draft
0xRozier wants to merge 6 commits intopola-rs:mainfrom
Draft
fix: Skip statistics deserialization for Null columns in Parquet#270210xRozier wants to merge 6 commits intopola-rs:mainfrom
0xRozier wants to merge 6 commits intopola-rs:mainfrom
Conversation
Add test for predicate pushdown with null column schema override
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27021 +/- ##
==========================================
+ Coverage 80.92% 81.39% +0.46%
==========================================
Files 1809 1809
Lines 249500 249497 -3
Branches 3140 3140
==========================================
+ Hits 201919 203078 +1159
+ Misses 46776 45614 -1162
Partials 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26974
Return
Ok(None)early forD::Nullindeserialize_all, consistent withDictionary,FixedSizeList, andStruct. This prevents aShapeErrorcaused by incomplete statistics arrays when predicate pushdown is used on a Null column with a schema override.No use of AI