Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #26995 +/- ##
==========================================
- Coverage 81.78% 81.78% -0.01%
==========================================
Files 1809 1810 +1
Lines 249417 249518 +101
Branches 3141 3141
==========================================
+ Hits 203980 204057 +77
- Misses 44632 44656 +24
Partials 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ritchie46
reviewed
Mar 23, 2026
| file_path_provider=lambda _: io.BytesIO(), | ||
| max_rows_per_file=1, | ||
| ), | ||
| _sinked_paths_callback=lambda _: None, |
Member
There was a problem hiding this comment.
Thinking aloud here, but can we make this callback only exists in IR? I don't think it should live in DSL.
80700f9 to
22009cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For sink_iceberg / polars cloud.