Use windows from UISceneDelegate lifecycle#1051
Open
opiotr wants to merge 2 commits intopointfreeco:mainfrom
Open
Use windows from UISceneDelegate lifecycle#1051opiotr wants to merge 2 commits intopointfreeco:mainfrom
opiotr wants to merge 2 commits intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After migrating to UISceneDelegate lifecycle, snapshot tests failed with pixels mismatch due to incorrect safe area insets being applied. Also other sizing issues appeared which caused fails for currently recorded view's snapshots.
Root Cause
The internal Window class was not attached to the active UIWindowScene, causing inconsistent behavior when rendering views.
Proposed changes
getKeyWindow()methodWindowclass initializer