fix(domino-maker): cuttable grid, printable divider, A4 print, hub dark sync - #52
Merged
Merged
Conversation
…rk sync Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polishes the Domino Card Maker tool from #51 to address three asks: make it fit the KlassKit aesthetic (incl. hub dark-mode sync), lay tiles out as a gapless cuttable grid that still reads as a domino, and fix printing (divider line, A4 default, no extra blank pages). All edits are in
apps/tools/domino-maker/index.html.1. Hub dark-mode sync. The hub stores theme via
Storage.set→localStorage[theme_hub] = JSON.stringify('dark'), i.e. the quoted string"dark". The tool compared the raw value=== 'dark', which never matched. Fixed with a defensive parse:The tool's own
theme_domino-makerchoice still takes precedence over the hub (unchanged precedence). Also forced tile text color to#1e293bso words stay readable on the always-white tiles in dark mode (previously inherited the light body text and became near-invisible).2. Cuttable domino grid.
.pagegridgap: 9mm 5mm → 0and.domino-tileborder-radius: 9px → 0, so tiles sit edge-to-edge and their borders form one continuous grid you can cut in straight lines. Each tile is still a domino: two.domino-halfs split by a centre divider. Shared tile borders (between dominoes) read as 2px+2px cut lines while the single 2px centre divider reads as the domino hinge.3. Print fixes.
background-colorinsideoverflow:hidden→ didn't print without Chrome's "Background graphics". Changed toborder-left: 2px solid #1e293b(borders always print) +print-color-adjust: exact.@page { size: A4; margin: 0 }enforces A4 by default (verified 2 pages under both "Default" and "None" margins).height: 297mmon a 297mm box; print.pageheight set to296mm, and on-screen container/gaps zeroed in print so nothing pushes content onto an extra sheet.Verified in-browser: gapless grid, hub→tool dark sync, readable tiles in dark mode, and print preview showing exactly 2 A4 pages with visible dividers.
Link to Devin session: https://app.devin.ai/sessions/6a816cc7fd9a480a975d22ffdde85c3a
Requested by: @pod-III