Skip to content

feat: add option to only include listed types and config#168

Closed
cekpowell wants to merge 3 commits intopluginpal:masterfrom
cekpowell:master
Closed

feat: add option to only include listed types and config#168
cekpowell wants to merge 3 commits intopluginpal:masterfrom
cekpowell:master

Conversation

@cekpowell
Copy link

What does it do?

  • Add additional config to the plugin to support including only certain types (includeTypes) and certain config (includeConfig)
  • The behaviour of these options is as follows:
    • If the included lists are empty: All types/config are synced
    • If the included list has items: Only the types/config in the list are synced
    • If the included and excluded lists both have items: Only the types in included which are not in excluded are synced (i.e., excluded lists take priority).

Why is it needed?

I only want the plugin to sync certain types of config.

How to test it?

Follow the steps to build the playground environment. Provide config options for includeTypes or includeConfig. Run an export. Only the provided items will be exported.

Related issue(s)/PR(s)

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

I've just left a couple of small comments, but then we can get this merged.

@cekpowell
Copy link
Author

All actioned! Thanks - silly from me haha!

@boazpoolman
Copy link
Member

Sweet! Then just one more request.

The docs of this plugin are actually hosted in a different repository, this one:
https://github.com/pluginpal/docs.

Could you document this new setting in there?

@cekpowell
Copy link
Author

Yup - can do. Do you want me to do the same flow of fork, and create a PR ?

@boazpoolman
Copy link
Member

Same flow yes.

Sorry for the inconvenience. I strive to include the related docs within the corresponding repository.
This is on our roadmap.

@cekpowell
Copy link
Author

No inconvenience at all - docs are super important.

https://github.com/pluginpal/docs/pull/4

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I'll get this merged and released asap.

@cekpowell
Copy link
Author

thanks so much!

@cekpowell
Copy link
Author

@boazpoolman Any chance we could get this merged in ? Looking to build out the feature that makes use of it this week if thats okay !

@AtiX
Copy link

AtiX commented May 30, 2025

@boazpoolman @cekpowell I just stumbled upon this. Any chance getting this merged? We would also benefit from those features.

@cekpowell cekpowell closed this Jun 19, 2025
@cekpowell
Copy link
Author

@boazpoolman closing this PR for inactivity. Feel free to re-open if you want to get it merged :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants