Skip to content

feat: add FetchItems endpoint and missing Item model fields#31

Open
bernardoveras wants to merge 1 commit intopluggyai:masterfrom
bernardoveras:feat/fetch-items-endpoint
Open

feat: add FetchItems endpoint and missing Item model fields#31
bernardoveras wants to merge 1 commit intopluggyai:masterfrom
bernardoveras:feat/fetch-items-endpoint

Conversation

@bernardoveras
Copy link
Copy Markdown

Add GET /items support via FetchItems() method with optional pagination through new ItemListParameters class. Also add missing Item fields: userAction, autoSyncDisabledAt, consentExpiresAt, products, and oauthRedirectUri.

Add GET /items support via FetchItems() method with optional pagination
through new ItemListParameters class. Also add missing Item fields:
userAction, autoSyncDisabledAt, consentExpiresAt, products, and
oauthRedirectUri.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bernardoveras bernardoveras requested review from a team and Gabrielpanga as code owners March 10, 2026 17:53
@Gabrielpanga
Copy link
Copy Markdown
Member

Hi @bernardoveras thanks for the pr!

Currently listing items is not available in the api, but we are in internal discussions to liberate that for users to list the connections.

Copy link
Copy Markdown
Member

@Gabrielpanga Gabrielpanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Clean, well-structured PR that follows existing SDK patterns. A few observations:

Looks good:

  • FetchItems follows the same pattern as FetchAccounts, FetchInvestmentTransactions, etc.
  • ItemListParameters with ToQueryStrings() matches the existing parameter class pattern.
  • New Item fields use appropriate types (DateTime? for nullable timestamps, IList<ProductType> for products).
  • Optional parameter with null default is clean.

Minor suggestions (non-blocking):

  • UserAction is typed as string. If the API returns a fixed set of values (e.g. "NEEDS_RECONNECT", "WAITING_USER_INPUT"), consider creating an enum like ItemStatus for type safety. Fine to defer if the set of values is still evolving on the API side.
  • OauthRedirectUri could arguably be Uri instead of string, but string is consistent with how other URI fields are likely handled in the SDK, so this is fine.

No issues found. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants