feat: add FetchItems endpoint and missing Item model fields#31
Open
bernardoveras wants to merge 1 commit intopluggyai:masterfrom
Open
feat: add FetchItems endpoint and missing Item model fields#31bernardoveras wants to merge 1 commit intopluggyai:masterfrom
bernardoveras wants to merge 1 commit intopluggyai:masterfrom
Conversation
Add GET /items support via FetchItems() method with optional pagination through new ItemListParameters class. Also add missing Item fields: userAction, autoSyncDisabledAt, consentExpiresAt, products, and oauthRedirectUri. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Hi @bernardoveras thanks for the pr! Currently listing items is not available in the api, but we are in internal discussions to liberate that for users to list the connections. |
Gabrielpanga
approved these changes
Apr 4, 2026
Member
Gabrielpanga
left a comment
There was a problem hiding this comment.
🤖 AI Review
Clean, well-structured PR that follows existing SDK patterns. A few observations:
Looks good:
FetchItemsfollows the same pattern asFetchAccounts,FetchInvestmentTransactions, etc.ItemListParameterswithToQueryStrings()matches the existing parameter class pattern.- New
Itemfields use appropriate types (DateTime?for nullable timestamps,IList<ProductType>for products). - Optional parameter with
nulldefault is clean.
Minor suggestions (non-blocking):
UserActionis typed asstring. If the API returns a fixed set of values (e.g."NEEDS_RECONNECT","WAITING_USER_INPUT"), consider creating an enum likeItemStatusfor type safety. Fine to defer if the set of values is still evolving on the API side.OauthRedirectUricould arguably beUriinstead ofstring, butstringis consistent with how other URI fields are likely handled in the SDK, so this is fine.
No issues found. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GET /items support via FetchItems() method with optional pagination through new ItemListParameters class. Also add missing Item fields: userAction, autoSyncDisabledAt, consentExpiresAt, products, and oauthRedirectUri.