fix(line): correct pointSymbol datum type to match runtime data#2824
Open
restareaByWeezy wants to merge 1 commit intoplouc:masterfrom
Open
fix(line): correct pointSymbol datum type to match runtime data#2824restareaByWeezy wants to merge 1 commit intoplouc:masterfrom
restareaByWeezy wants to merge 1 commit intoplouc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2818
The
pointSymbolprop was typed asDotsItemSymbolComponent<Point<Series>>, but at runtime thedatumpassed to the symbol component is actuallyPoint<Series>['data'](i.e. the raw data item), not the fullPointobject. You can see this inPoints.tsxwheredatum: point.datais mapped before passing toDotsItem.Changed the type to
DotsItemSymbolComponent<Point<Series>['data']>sodatum.stalled(or whatever custom fields are on the data) is correctly typed without needingdatum.data.stalled.Also removed the
as anycast on thesymbolprop inPoints.tsxsince the types now line up.