Remove unused hasStartPose field and fix TypeScript warning#837
Merged
slimbuck merged 4 commits intoplaycanvas:mainfrom Mar 13, 2026
Merged
Remove unused hasStartPose field and fix TypeScript warning#837slimbuck merged 4 commits intoplaycanvas:mainfrom
hasStartPose field and fix TypeScript warning#837slimbuck merged 4 commits intoplaycanvas:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies viewer/publish experience settings by removing the redundant hasStartPose flag (since cameras being non-empty already implies a start pose) and fixes a TypeScript implicit-any[] warning in the file import pipeline.
Changes:
- Remove
hasStartPosefromExperienceSettingsand stop emitting it from export/publish flows. - Inline the “has start pose” check by deriving
camerasdirectly from the current camera pose. - Add an explicit
(Splat | undefined)[]type annotation to theresultarray inimportFilesto address TS7034/TS7005 warnings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/splat-serialize.ts |
Removes hasStartPose from the exported ExperienceSettings type. |
src/ui/export-popup.ts |
Stops computing/persisting hasStartPose; derives cameras from current pose. |
src/ui/publish-settings-dialog.ts |
Same cleanup as export popup for publish settings assembly. |
src/file-handler.ts |
Adds an explicit type annotation for the result array to resolve TS warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stechdrive
pushed a commit
to stechdrive/supersplat-cameraframes
that referenced
this pull request
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasStartPosefield fromExperienceSettingsand its usage in the export and publish dialogs. The presence of entries in thecamerasarray already indicates a start pose, making the separate boolean unnecessary.resultarray infile-handler.tsto resolve TS7034/TS7005 build warnings about implicitany[]type.Changed Files
src/splat-serialize.ts— removehasStartPosefromExperienceSettingstypesrc/ui/export-popup.ts— inline camera pose check, removehasStartPosefrom settingssrc/ui/publish-settings-dialog.ts— same cleanup as export popupsrc/file-handler.ts— add(Splat | undefined)[]type annotation toresult