Skip to content

Restore Publint for Publishing#144

Merged
slimbuck merged 1 commit intoplaycanvas:mainfrom
slimbuck:pub-dev
Jan 14, 2026
Merged

Restore Publint for Publishing#144
slimbuck merged 1 commit intoplaycanvas:mainfrom
slimbuck:pub-dev

Conversation

@slimbuck
Copy link
Member

Restore Publint for Publishing

Problem

The publish workflow in .github/workflows/publish.yml runs npm run publint at line 36, but in PR #137 ("Refactor: Library + CLI Architecture"), both the publint devDependency and the publint npm script were accidentally removed from package.json.

This causes the publish job to fail when triggered on v0.17.0 tag push.

Solution

Restore the publint package and script to package.json.

Changes

package.json

  1. Add publint back to devDependencies (use latest version 0.3.16 or newer)
  2. Add the publint script back to the scripts section
"devDependencies": {
  ...
  "publint": "0.3.16",
  ...
}
"scripts": {
  ...
  "publint": "publint",
  ...
}

@slimbuck slimbuck requested review from a team and Copilot January 14, 2026 18:30
@slimbuck slimbuck self-assigned this Jan 14, 2026
@slimbuck slimbuck added the bug Something isn't working label Jan 14, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the publint package and script that were accidentally removed in PR #137, which is causing the publish workflow to fail. The publint tool validates npm package configurations for proper publishing.

Changes:

  • Added publint 0.3.16 as a devDependency
  • Added publint npm script to enable npm run publint
  • Updated package-lock.json with publint and its dependencies
  • Reordered exports field to place types before import

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Restored publint devDependency and script; reordered exports field
package-lock.json Added publint package and dependencies (@publint/pack, package-manager-detector, picocolors, mri, sade)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slimbuck slimbuck merged commit cbe1e1e into playcanvas:main Jan 14, 2026
8 checks passed
@slimbuck slimbuck deleted the pub-dev branch January 14, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants