Fix crash on listing offset of unknown partition#246
Merged
ShogunPanda merged 1 commit intoplatformatic:mainfrom Mar 10, 2026
Merged
Fix crash on listing offset of unknown partition#246ShogunPanda merged 1 commit intoplatformatic:mainfrom
ShogunPanda merged 1 commit intoplatformatic:mainfrom
Conversation
ShogunPanda
requested changes
Mar 9, 2026
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
I think there is a an easier way than a semver-major change.
Pleasee my comment below.
lp247
force-pushed
the
fix/unknown_partition
branch
from
5f7496a to
1dd3d85
Compare
ShogunPanda
approved these changes
Mar 9, 2026
Contributor
|
@lp247 The CI is failing, can you please fix it? |
This change fixes uncaught exceptions in the Admin client class's within a topic, which are then passed to the function via options. This case throws a UserError with an appropriate error message concerning invalid partitions. As the case of invalid partitions is semantically the same as the case of invalid topics, we also throw a UserError for the case of invalid topics inside a metadata call (mapped from ResponseError). On-behalf-of: @SAP ospo@sap.com Signed-off-by: Peter Lehnhardt <peter.lehnhardt@sap.com>
lp247
force-pushed
the
fix/unknown_partition
branch
from
2a5acab to
bd5f7a1
Compare
Contributor
Author
|
@ShogunPanda I missed some tests, but they should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes uncaught exceptions in the Admin client class's
#listOffsetsfunction that occur when invalid partitions are declared within a topic, which are then passed to the function via options. This case throws a UserError with an appropriate error message concerning invalid partitions. As the case of invalid partitions is semantically the same as the case of invalid topics, we also throw a UserError for the case of invalid topics inside a metadata call (mapped from ResponseError)On-behalf-of: @SAP ospo@sap.com