Skip to content

Switch to async pbkdf2#237

Merged
ShogunPanda merged 1 commit intoplatformatic:mainfrom
kibertoad:feat/async-pbkdf
Mar 3, 2026
Merged

Switch to async pbkdf2#237
ShogunPanda merged 1 commit intoplatformatic:mainfrom
kibertoad:feat/async-pbkdf

Conversation

@kibertoad
Copy link
Copy Markdown
Contributor

@kibertoad kibertoad commented Mar 3, 2026

We've noticed that there our service using platformatic Kafka blocks event loop for a significant amount of time on start/init. This PR addresses the most likely culprit - synchronous pbkdf2 flow

This should transparently make the default flow non-blocking, without affecting any of the APIs exposed to the end user, hence it should be non-breaking


Signed-off-by: Igor Savin iselwin@gmail.com

---
Signed-off-by: Igor Savin <iselwin@gmail.com>
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from ShogunPanda March 3, 2026 14:38
@ShogunPanda ShogunPanda merged commit 8bd02ca into platformatic:main Mar 3, 2026
19 checks passed
@kibertoad
Copy link
Copy Markdown
Contributor Author

@ShogunPanda thank you! Can I ask to release a new version so that we could assess the impact?

@ShogunPanda
Copy link
Copy Markdown
Contributor

@kibertoad I plan to draft a release today.

@ShogunPanda
Copy link
Copy Markdown
Contributor

@kibertoad As promises, 1.29.0 is out! 🎉

@kibertoad
Copy link
Copy Markdown
Contributor Author

@ShogunPanda much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants