feat: Support Confluent Schema Registry.#203
Merged
ShogunPanda merged 4 commits intomainfrom Feb 20, 2026
Merged
Conversation
ShogunPanda
force-pushed
the
registries
branch
2 times, most recently
from
6f2451e to
b0a57f3
Compare
ShogunPanda
force-pushed
the
registries
branch
from
103faa8 to
6a99a24
Compare
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
force-pushed
the
registries
branch
from
26796c7 to
0568c1b
Compare
mcollina
approved these changes
Feb 20, 2026
| bootstrapBrokers: kafkaSingleBootstrapServers, | ||
| strict: true, | ||
| registry: consumerRegistry, | ||
| deserializers: consumerRegistry.getDeserializers() |
Member
There was a problem hiding this comment.
I dont like this should be set twice.
src/registries/confluent.ts
Outdated
| } | ||
|
|
||
| this.#schemas.set(schemaId, avro.Type.forSchema(JSON.parse((responseBody as { schema: string }).schema))) | ||
| process.nextTick(callback) |
Member
There was a problem hiding this comment.
wait. Why there is async await and a callback?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137.
Fixes #189.