Open
Conversation
Because you renamed the project, the repository URL for the project has changed. In the browser, GitHub properly redirects to the new repo, but if a user has the GitHub app installed, it simply says "Loading repository failed!" because it simply takes the URL and parses that into an API request. The GitHub API does not handle repository rename redirects. See: http://stackoverflow.com/questions/22715169/github-api-returns-404-but-default-http-request-returns-301 https://github.com/github/android/blob/e18693727bc62bc2598cd7575130cbf3b8f341eb/app/src/main/java/com/github/mobile/ui/repo/RepositoryViewActivity.java#L121 https://github.com/github/android/blob/e18693727bc62bc2598cd7575130cbf3b8f341eb/app/src/main/java/com/github/mobile/core/repo/RefreshRepositoryTask.java#L55 https://github.com/eclipse/egit-github/blob/bcdf39cca5ef0dd828f960030a2febba1e56a253/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java#L580-L607
Contributor
Author
|
I thought about sending a pull request to the GitHub android app or egit-github to make it perform a Really, GitHub should just make their API respond to the old repo names with a |
Owner
|
sorry for seeing this pull-request so late. seems that github will redirect it now. 👯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because you renamed the project, the repository URL for the project has
changed. In the browser, GitHub properly redirects to the new repo, but
if a user has the GitHub app installed, it simply says "Loading
repository failed!" because it simply takes the URL and parses that into
an API request. The GitHub API does not handle repository rename
redirects.
See:
http://stackoverflow.com/questions/22715169/github-api-returns-404-but-default-http-request-returns-301
https://github.com/github/android/blob/e18693727bc62bc2598cd7575130cbf3b8f341eb/app/src/main/java/com/github/mobile/ui/repo/RepositoryViewActivity.java#L121
https://github.com/github/android/blob/e18693727bc62bc2598cd7575130cbf3b8f341eb/app/src/main/java/com/github/mobile/core/repo/RefreshRepositoryTask.java#L55
https://github.com/eclipse/egit-github/blob/bcdf39cca5ef0dd828f960030a2febba1e56a253/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/RepositoryService.java#L580-L607