Draft
Conversation
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I inspected the latest successful
mainruns invitessio/vitessusinggh:unit_test.yml: run23294293582cluster_endtoend.yml: run23294293585Across those two workflows, the slowest job was
Run endtoend tests on Cluster (onlineddl_vrepl_suite)at34m22s. The slowest unit-test job in the same investigation window was only15m38s, so this cluster shard was the real bottleneck.From the upstream job log for
onlineddl_vrepl_suite:Setup MySQL:15m27sRun cluster endtoend test:17m51sgo/test/endtoend/onlineddl/vrepl_suitein17m20.031sTestVreplSuiteSchemaChangesin1023.01sThe root cause is that
go/test/endtoend/onlineddl/vrepl_suiteputs 129 schema-change cases behind a single top-level e2e test, so all of that work is serialized inside one shard.I also checked open PRs in both
vitessio/vitessandplanetscale/vitessbefore making this change. There is active draft work foronlineddl_vrepl_stress_suite, but nothing open foronlineddl_vrepl_suiteitself.This change keeps the same end-to-end coverage but splits
TestVreplSuiteSchemaChangesinto two balanced top-level tests and maps them to two independent CI shards:onlineddl_vrepl_suite_group1onlineddl_vrepl_suite_group2Using the upstream per-subtest timings from the inspected successful run, the two groups balance almost exactly evenly at
510.94sand511.03sof test body time. That should reduce the current~34moutlier shard to roughly~24mper shard in CI, which brings it below the currentvtorchotspot while preserving the existing assertions.Related Issue(s)
None.
Checklist
Deployment Notes
No deployment impact. This only changes CI scheduling for an existing end-to-end suite.
AI Disclosure
This PR was authored with GPT-5 assistance. I used AI to inspect the upstream CI timings, prepare the shard split, run the local validation, and draft this PR description.
Local validation
After building Vitess and installing the same local e2e dependencies the cluster workflow expects, I ran both new shards through the Vitess e2e harness with a clean
VTDATAROOTbefore each run:Results:
onlineddl_vrepl_suite_group1:PASS Package ... (8m45.028s)/local.onlineddl_vrepl_suite_group1: PASSED in 8m46.9sonlineddl_vrepl_suite_group2:PASS Package ... (8m49.361s)/local.onlineddl_vrepl_suite_group2: PASSED in 8m51.6s