Open
Conversation
(cherry picked from commit 35b51a01b0f1a0a711896000d8aa7e2660fc2faf)
(cherry picked from commit 5c8b07519892de6a3a057aa0755b2e368d2a47db)
(cherry picked from commit b1dcb38657f80d662ab44abd686693b97cf4ee79)
|
thanks for the effort to create this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that the version of libdmg-hfsplus inside the xpwn project has some nice features that the version in the libdmg-hfsplus project is missing (I'm specially interested in the hfs decompression feature). I cherry-picked the three commits that contained libdmg-hfsplus changes from xpwn and merged them into a "from-xpwn" branch.
So this merge commit is a bit unusual as it doesn't contain any code that I wrote, it is just code from your own xpwn repo. Is there a reason the changes are not in the libdmg-hfsplus repo? Otherwise, feel free to merge this request.