This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Cocoapods spec#154
Open
wileykestner wants to merge 3 commits intopivotal-legacy:masterfrom
wileykestner:cocoapods_spec
Open
Cocoapods spec#154wileykestner wants to merge 3 commits intopivotal-legacy:masterfrom wileykestner:cocoapods_spec
wileykestner wants to merge 3 commits intopivotal-legacy:masterfrom
wileykestner:cocoapods_spec
Conversation
- Use CFDataRef, CFEqual, CFRelease instead of using NSData pointer casts
Contributor
|
We should really see about updating this (ideally including targets for each platform!) and getting it merged. It is really easy to inadvertently break the podspec at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is a proof-of-concept showing how we could test whether or not PCK is deployable via CocoaPods.
Try it out with the new command:
rake cocoapods:specThis command pulls PCK into the CocoaPodsSampleProject folder, builds an iOS app target, and runs the PCK Foundation-Core and UIKit-Core specs. It proves that at the current revision, those two libraries are deployable via Cocoapods.
There are some potential drawbacks or omissions to this approach, but it is mean to start a conversation. Here are the outstanding issues that I can think of:
• This branch currently only tests that two of the seven PCK static libraries (Foundation-Core, UIKit-Core)
• Maintainers will have to remember to add their spec implementations (.mm files) to the
CocoaPodsSampleProjectTeststarget.