Fix KeyedVectors.add_vectors() error when use most_similar#3320
Open
s2terminal wants to merge 1 commit intopiskvorky:developfrom
Open
Fix KeyedVectors.add_vectors() error when use most_similar#3320s2terminal wants to merge 1 commit intopiskvorky:developfrom
KeyedVectors.add_vectors() error when use most_similar#3320s2terminal wants to merge 1 commit intopiskvorky:developfrom
Conversation
Collaborator
|
Needs a test. The example from the issue description is probably good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing one of the issues in #3224
If I call
most_similar()before doingadd_vectors()and then callmost_similar()again after doingadd_vectors(), I get aValueError: operands could not be broadcast together with shapes.This error occurs because
len(vectors)andlen(vectors.norms)do not match.To resolve this error, I have used fill_norms to match
len(vectors)andlen(vectors.norms).