Update (current|pending)RemoteDescription SDP after addIceCandidate#3413
Draft
Update (current|pending)RemoteDescription SDP after addIceCandidate#3413
Conversation
fippo
force-pushed
the
addicecandidate-update-remotedescription
branch
from
a992540 to
85ba51d
Compare
Contributor
Author
|
@JoTurk 🤔 any idea what causes the test failures? They are either totally uncorrelated or I need to move the test to the go layer... |
Member
|
@fippo there is a race in attribute. |
JoTurk
reviewed
Apr 17, 2026
Comment on lines
+2128
to
+2135
| if err := pc.pendingRemoteDescription.UpdateWithCandidate(candidate); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| if pc.currentRemoteDescription != nil { | ||
| if err := pc.currentRemoteDescription.UpdateWithCandidate(candidate); err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
This updates the candidates' attributes while startRTP is reading them. which cases the test to fail with race detected.
Contributor
Author
There was a problem hiding this comment.
but why does startRtp look at the candidates in the SDP instead of getting them from the ICE agent? Also why does anything RTP not consider ICE a virtual socket? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as described in
https://w3c.github.io/webrtc-pc/#dom-peerconnection-addicecandidate
(noticed while pondering pion/ice#912 (comment))