Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
===========================================
- Coverage 77.93% 63.50% -14.43%
===========================================
Files 89 67 -22
Lines 10546 3957 -6589
===========================================
- Hits 8219 2513 -5706
+ Misses 1838 1316 -522
+ Partials 489 128 -361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jech
force-pushed
the
nack-test-2
branch
3 times, most recently
from
fc9d59e to
7bfc4bf
Compare
One variable was misnamed, and we never checked for the end of the RTCP loop.
This is another end-to-end test for the NACK interceptor, it verifies that we actually get a reply to a NACK, both with and without a negotiated RTX track.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another end-to-end test, this time for the NACK responder.
It verifies that we actually receive a reply to a NACK,
both when we negotiate an RTX track and when we don't.
This currently fails, for unknown reasons.